Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme module react #1799

Merged
merged 17 commits into from
Dec 21, 2021
Merged

Theme module react #1799

merged 17 commits into from
Dec 21, 2021

Conversation

joeizang
Copy link
Collaborator

Fixes #1719

@joeizang joeizang marked this pull request as ready for review November 26, 2021 13:56
nx.json Show resolved Hide resolved
@github-actions
Copy link

.eslintrc.json Outdated
@@ -0,0 +1,35 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be removed i believe

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mistaken artifact from scaffolding the project. It should have been .eslintrc and the contents too were different. I have since fix this issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this file is at the root, shouldn't it be removed?

@yann300 yann300 force-pushed the theme-Module-react branch 2 times, most recently from 92c1a4f to 99521ae Compare December 21, 2021 14:14
@yann300 yann300 merged commit a902df4 into master Dec 21, 2021
@yann300 yann300 deleted the theme-Module-react branch December 21, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move theme-module to react.js
4 participants